minecraft-pi-reborn
/
symbol-processor
1
1
Fork 1
Code Issues Pull Requests Activity

Re-add _non_virtual and add _unedited for methods #18

Closed
bigjango13 wants to merge 2 commits from bigjango13/symbol-processor:master into master
pull from: bigjango13/symbol-processor:master
merge into: minecraft-pi-reborn:master
Conversation 1 Commits 2 Files Changed 3 +25 -2
bigjango13 commented 2024-04-08 05:12:41 +00:00
Contributor
Copy Link

This also adds some basic error checking to def.nanorc (kind of like nanorc.nanorc, but less perfect).

I know _non_virtual was removed for a reason, and I'm assuming it was the recent change to the 3.0.0 API. However, I think that this change will help smooth over a few issues with the current API:

  • Circumventing the system, this sounds bad, but it some cases it may be needed in the same way overwrite_call is needed for MCPI, everything from bugs in Reborn to just things Reborn had no way to expect. There are tons of examples from avoiding setting is_hurt to rendering hearts for decor to custom keybindings.
  • This won't suddenly make something possible, it will just make it less ugly, and I really like how much prettier the symbols processor is making things so it seems a shame to keep an useful edgecase ugly.
This also adds some basic error checking to `def.nanorc` (kind of like nanorc.nanorc, but less perfect). I know `_non_virtual` was removed for a reason, and I'm assuming it was the recent change to the 3.0.0 API. However, I think that this change will help smooth over a few issues with the current API: - Circumventing the system, this sounds bad, but it some cases it may be needed in the same way `overwrite_call` is needed for MCPI, everything from bugs in Reborn to just things Reborn had no way to expect. There are tons of examples from [avoiding setting `is_hurt`](https://github.com/MCPI-Revival/minecraft-pi-reborn/blob/cf6989bed262580e2f90edf938430be1f6f728ff/mods/src/death/death.cpp#L68) to [rendering hearts for decor](<https://github.com/MCPI-Revival/minecraft-pi-reborn/blob/cf6989bed262580e2f90edf938430be1f6f728ff/mods/src/misc/misc.cpp#L29>) to [custom keybindings](<https://github.com/MCPI-Revival/minecraft-pi-reborn/blob/cf6989bed262580e2f90edf938430be1f6f728ff/mods/src/sign/sign.cpp#L13>). - This won't suddenly make something possible, it will just make it less ugly, and I really like how much prettier the symbols processor is making things so it seems a shame to keep an useful edgecase ugly.
bigjango13 added 1 commit 2024-04-08 05:12:42 +00:00
bigjango13 added 1 commit 2024-05-04 07:14:07 +00:00
TheBrokenRail commented 2024-05-05 04:43:30 +00:00
Owner
Copy Link

I added some stuff from this PR in a separate commit.

I added some stuff from this PR in a separate commit.
TheBrokenRail closed this pull request 2024-05-05 04:43:30 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: minecraft-pi-reborn/symbol-processor#18
No description provided.
Delete Branch "bigjango13/symbol-processor:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?