Update ARM GNU toolchain to version 12.3-rel1 #64
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "taylorthemushroom/minecraft-pi-reborn:master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This should fix issues with mod development pertaining to the outdated version of libc on the old toolchain. I also had to rewrite the AppPlatform::readAssetFile function to mitigate a null dereference error thrown by the new toolchain.
Tested operational on Debian Unstable (sid) as of September 24, 2023.
Did they finally fix https://bugs.linaro.org/show_bug.cgi?id=5825?
Also, where was the null de-reference coming from in the old code?
Finally, what issues are being caused by an old glibc?
https://bugs.linaro.org/show_bug.cgi?id=5825 I was unable to reproduce the bug in this bug report using the latest toolchain version and the provided test cases. Looks like they might have fixed this bug after all, if my admittedly ancient i7-3700K has anything to say about it. :P
The new toolchain was erroring on line 20
std::string str((std::istreambuf_iterator<char>(stream)), std::istreambuf_iterator<char>());
in the old code, although the compiler output was admittedly a little hard to parse considering all the fluff it output regarding inlined functions and errors allegedly coming from thestreambuf
header itself. I was able to find the offending line through the weeds, though I am not a good enough C++ programmer to be able to find the problem with that line on first glance, hence the rewrite.I already documented this on the Discord server earlier, but on my development computer running the latest Debian unstable, MCPI Reborn up to the (as of now) current version will crash with the following error message when loading a compiled mod:
/tmp/.minecraft-pi-patched/Ks58eP: /home/tstephensen/src/minecraft-pi-reborn/out/client-amd64/usr/lib/minecraft-pi-reborn-client/sysroot/lib/libc.so.6: version 'GLIBC_2.34' not found (required by /home/tstephensen/.minecraft-pi/mods/libchat-commands.so)
This error is because the mod is being compiled using a newer version of libc (2.37) than the version found in the sysroot (2.33). I am able to reproduce this error on the latest master branch version, but this is fixed in the modified commit.