TheBrokenRail
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-04-03 07:19:21 +00:00
cf6989bed2 I need to sleep, here be dragons
b2a7fe3eaf C++-Ification!
Compare 2 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/symbol-processor 2024-04-03 07:19:00 +00:00
67c4adaa77 Pure Evil
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-04-02 19:21:46 +00:00
7739fb6b9b Update Dependency
TheBrokenRail pushed to master at minecraft-pi-reborn/symbol-processor 2024-04-02 19:21:15 +00:00
842f05a288 Copy RTTI Info
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-03-19 04:26:02 +00:00
f3755387e8 Improve Mouse Sensitivity On Wayland
b1b28defd5 Small Change
18c5d34974 Ignore CLion Files
Compare 3 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-03-19 02:06:06 +00:00
76a66a0ba5 Sneak in Level_setTileEntity
a6ad1994de Remove left over check
8de638eb1a Make chat history edits saved temporarily
5e5088e3ef Move chat history into chat
a6e0cd8f13 Fix history editing bug
Compare 6 commits »
TheBrokenRail merged pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-19 02:06:04 +00:00
Add chat history
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-19 00:54:47 +00:00
Add chat history

Well, that's annoying. I don't want to mess with typeid, so I guess this is the best solution.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 23:59:43 +00:00
Add chat history

What is the issue with HOOK and non-extern"C"-functions?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 23:55:49 +00:00
Add chat history

Is this check needed? Because if old_pos == self->history_pos, wouldn't that just call setText with the current text, doing nothing?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 23:47:43 +00:00
Add chat history

Why? This seems really useless. Considering it needs std::vector... which only exists on C++.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 22:47:18 +00:00
Add chat history

I'm basing this off GNOME Terminal, which IMO, has a much superior history function to Minecraft.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 22:42:19 +00:00
Add chat history

Hmm, that could be a problem.

Maybe when ChatScreen is created, it copies history into it's own property (history_local?). That gets modified when you hit up/down. But when you hit enter,…

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 22:20:23 +00:00
Add chat history

This all looks good, but I have one concern.

What if I type something and then accidentally hit up/down, what happens to what I typed.

I'd suggest this system (forgive the pseudo-code):

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 22:12:57 +00:00
Add chat history

What's the point of this check?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 22:12:09 +00:00
Add chat history

This should probably be in one big if (self->chat->isFocused()) statement.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 22:10:26 +00:00
Add chat history

Yup, it's EntityRenderer::entityRenderDispatcher.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-18 22:06:59 +00:00
Add chat history

This seems wrong. I think this address actually refers to an EntityRenderDispatcher. Which then has a first property of ItemInHandRenderer.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#100 2024-03-10 05:25:32 +00:00
Add chat history

What do you mean? Just add code to keyPressed in chat/ui.cpp.