TheBrokenRail
1 Followers · 0 Following
Repositories
17
 Projects Packages Public Activity Starred Repositories
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Should Fail\n be a constant?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

I still think you should be able to enable a "real mode" that allows you to get the real data.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

This and all other places where minecraft->player is accessed should have a NULL-check. Especially if the player is allowed to be removed. And of course, it is NULL on the dedicated server.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

What's the ,1,?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Should this be a WARN?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

This should be under a feature flag.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Maybe move this to misc/api.cpp?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Altogether looks pretty good. I just have a few nitpicks.

TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-24 01:35:29 +00:00
cbca78ec16 Try To Fix server.properties Generation
65190afe73 Fix Rare Segfault
Compare 2 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-23 22:52:34 +00:00
be3ccae7c1 Hide Block Outline When GUI Is Hidden
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-23 03:41:02 +00:00
00d193e732 Fix Bad Error
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-23 01:22:03 +00:00
65ee4d8a78 Shrink Icon For Flatpak
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-23 00:26:09 +00:00
3598fbc922 Revert Bad Idea
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-23 00:25:22 +00:00
6da5634a01 Revert Bad Idea
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-23 00:13:00 +00:00
b5e9a91f75 Test Crafting Remainder
18c6247e0c Fix Button Hovering
c525d69dc3 New Logo + Background!
Compare 3 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-21 06:54:19 +00:00
72eb1945cf Update Processor
5ca2a63b5e Allow Custom Commands
Compare 2 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/symbol-processor 2024-09-21 06:53:40 +00:00
f72c4f0567 Pass Original As Reference
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-21 05:56:03 +00:00
72e2c4947d Update Runtime
be1f3bf50e Fix Chat Example Mod
e2c82071c7 Server Changes
Compare 3 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/runtime 2024-09-21 05:54:50 +00:00
c13072404d Flatpak Fix
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-21 04:23:57 +00:00
9bb6b86c73 Some Tweaks
c0156336df Modding Changes
Compare 2 commits »