TheBrokenRail
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-30 00:15:15 +00:00
Port over most of the RaspberryJuice API

My idea is that legacy RJ clients can work more/less seamlessly, but modern clients can take full advantage of Reborn features.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-30 00:14:26 +00:00
Port over most of the RaspberryJuice API

Some suggestions/comments:

  • reborn.enableDangerMode -> reborn.disableCompatMode or reborn.enableRealMode
  • In RaspberryJuice compat mode (the default), it converts MCPI entity IDs to RJ…
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-09-29 04:49:12 +00:00
9bdde40f3f Click Buttons On Mouse Down
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 03:59:27 +00:00
Port over most of the RaspberryJuice API

I'm thinking that if RaspberryJuice compatibility is already being broken (with regards to entity IDs), then it should just be broken completely completely so Reborn can have a sane API.…

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 03:47:22 +00:00
Port over most of the RaspberryJuice API

I would recommend just blocking it

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 03:47:04 +00:00
Port over most of the RaspberryJuice API

player.setPos(0, 0, 0) would bring you to spawn

MCPI does this too. That's what OffsetPosTranslator does.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Uh, what?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Does this work? Removing a player sounds like it would break things. What if the server removes a remote player? What if a server removes the local player?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Do non-player entities with a type ID of 0 exist?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

What do you means? What are those commands supposed to do?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

I think it should be - instead of - -. Gitea renders this weird:

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Nitpick, but some of these bullets are capitalized and period-ed and some aren't.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Another nitpick, but coordinates should probably be in parentheses (ie. (x, y, z) instead of x, y, z).

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Is this also true in RaspberryJuice?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

This should be a masked link.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

If this is meant to be RaspberryJuice compatible, maybe it should convert Java IDs to MCPI IDs and vice versa?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

death.cpp also converts IDs to names, maybe this could be common code?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Maybe distance_between?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-09-25 02:40:51 +00:00
Port over most of the RaspberryJuice API

Is this a circular queue type situation where there is a head and a tail?