Why not call misc_get_entity_type
?
This is unused (probably a victim of a merge conflict).
Why was this removed?
Should this be extern "C"
? I know you've requested other method be un-mangled in the past.
There should probably be a note added about the Base64 encoding.
The "0",
is no longer accurate.
This is no longer the case.
In compat mode, this should be the name.
It does now.
And also the (Entity *)
casts.
Pretty sure this has the correct ID for non-local players now.
No, like the player hosting the server using chat.
I think that's because you passed NULL
to chat_send_message
.
That's for messages sent by the server host or in single-player.
This should be in a mods/api/api.h
header.
This should be minecraft->player
, otherwise chat_send_message
won't add the chat event.
IMO, chat_already_added
should be removed. Instead modify chat_is_sending
to be wrapped around chat_send_message
instead of _chat_send_message
. Then api
's injection can be changed to:
Shouldn't this be Base64-encoded in non-compat mode in case the username includes a `
This could probably be a loop: