TheBrokenRail
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

Why not call misc_get_entity_type?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

This is unused (probably a victim of a merge conflict).

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

Why was this removed?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

Should this be extern "C"? I know you've requested other method be un-mangled in the past.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

There should probably be a note added about the Base64 encoding.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

The "0", is no longer accurate.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

This is no longer the case.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

In compat mode, this should be the name.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:37:56 +00:00
Port over most of the RaspberryJuice API

It does now.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 03:07:21 +00:00
Port over most of the RaspberryJuice API

And also the (Entity *) casts.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-11-03 02:35:43 +00:00
Port over most of the RaspberryJuice API

Pretty sure this has the correct ID for non-local players now.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:26:50 +00:00
Port over most of the RaspberryJuice API

Just open a single player world and type something in chat:

image

image

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:19:19 +00:00
Port over most of the RaspberryJuice API

No, like the player hosting the server using chat.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:17:51 +00:00
Port over most of the RaspberryJuice API

I think that's because you passed NULL to chat_send_message.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:17:25 +00:00
Port over most of the RaspberryJuice API

That's for messages sent by the server host or in single-player.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:10:54 +00:00
Port over most of the RaspberryJuice API

This should be in a mods/api/api.h header.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:10:54 +00:00
Port over most of the RaspberryJuice API

This should be minecraft->player, otherwise chat_send_message won't add the chat event.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:10:54 +00:00
Port over most of the RaspberryJuice API

IMO, chat_already_added should be removed. Instead modify chat_is_sending to be wrapped around chat_send_message instead of _chat_send_message. Then api's injection can be changed to:

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:10:54 +00:00
Port over most of the RaspberryJuice API

Shouldn't this be Base64-encoded in non-compat mode in case the username includes a `

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#116 2024-10-30 08:10:54 +00:00
Port over most of the RaspberryJuice API

This could probably be a loop: