minecraft-pi-reborn/zenity
Archived
1
0
Fork 0
Code Pull Requests Activity

use g_value_dup_string when applicable (Fixes bug #527258). Patch from

Browse Source 
2008-04-10  Lucas Rocha  <lucasr@gnome.org>

	* src/tree.c (zenity_tree_dialog_get_selected,
	zenity_tree_dialog_toggle_get_selected): use g_value_dup_string when
	applicable (Fixes bug #527258). Patch from kraai@ftbfs.org.

svn path=/trunk/; revision=1352
This commit is contained in:
Lucas Rocha 2008-04-10 09:57:14 +00:00 committed by Lucas Almeida Rocha
parent eeb43bf65b
commit a740e32652
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2008-04-10 Lucas Rocha <lucasr@gnome.org>
* src/tree.c (zenity_tree_dialog_get_selected,
zenity_tree_dialog_toggle_get_selected): use g_value_dup_string when
applicable (Fixes bug #527258). Patch from kraai@ftbfs.org.
2008-03-30 Lucas Rocha <lucasr@gnome.org> 2008-03-30 Lucas Rocha <lucasr@gnome.org>
* src/msg.c (zenity_msg_construct_question_dialog): fix memory leak on * src/msg.c (zenity_msg_construct_question_dialog): fix memory leak on

8
src/tree.c
View File

@ -516,7 +516,7 @@ zenity_tree_dialog_get_selected (GtkTreeModel *model, GtkTreePath *path_buf, Gtk
for (i = 0; i < n_columns; i++) { for (i = 0; i < n_columns; i++) {
gtk_tree_model_get_value (model, iter, i, &value); gtk_tree_model_get_value (model, iter, i, &value);
selected = g_slist_append (selected, g_strdup (g_value_get_string (&value))); selected = g_slist_append (selected, g_value_dup_string (&value));
g_value_unset (&value); g_value_unset (&value);
} }
return; return;
@ -525,7 +525,7 @@ zenity_tree_dialog_get_selected (GtkTreeModel *model, GtkTreePath *path_buf, Gtk
for (i = 0; print_columns[i] != 0; i++) { for (i = 0; print_columns[i] != 0; i++) {
gtk_tree_model_get_value (model, iter, print_columns[i] - 1, &value); gtk_tree_model_get_value (model, iter, print_columns[i] - 1, &value);
selected = g_slist_append (selected, g_strdup (g_value_get_string (&value))); selected = g_slist_append (selected, g_value_dup_string (&value));
g_value_unset (&value); g_value_unset (&value);
} }
} }
@ -547,7 +547,7 @@ zenity_tree_dialog_toggle_get_selected (GtkTreeModel *model, GtkTreePath *path,
for (i = 1; i < n_columns; i++) { for (i = 1; i < n_columns; i++) {
gtk_tree_model_get_value (model, iter, i, &value); gtk_tree_model_get_value (model, iter, i, &value);
selected = g_slist_append (selected, g_strdup (g_value_get_string (&value))); selected = g_slist_append (selected, g_value_dup_string (&value));
g_value_unset (&value); g_value_unset (&value);
} }
g_value_unset (&toggle_value); g_value_unset (&toggle_value);
@ -557,7 +557,7 @@ zenity_tree_dialog_toggle_get_selected (GtkTreeModel *model, GtkTreePath *path,
for (i = 0; print_columns[i] != 0; i++) { for (i = 0; print_columns[i] != 0; i++) {
gtk_tree_model_get_value (model, iter, print_columns[i] - 1, &value); gtk_tree_model_get_value (model, iter, print_columns[i] - 1, &value);
selected = g_slist_append (selected, g_strdup (g_value_get_string (&value))); selected = g_slist_append (selected, g_value_dup_string (&value));
g_value_unset (&value); g_value_unset (&value);
} }
} }