minecraft-pi-reborn
/
minecraft-pi-reborn
7
11
Fork 13
Code Issues 5 Pull Requests 1 Actions Releases 3 Activity

Add chat history #100

Merged
TheBrokenRail merged 6 commits from bigjango13/minecraft-pi-reborn:master into master 2024-03-19 02:06:04 +00:00
Conversation 10 Commits 6 Files Changed 30 +2 -8
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a6ad1994de - Show all commits

10
mods/src/chat/ui.cpp
View File

@ -100,23 +100,17 @@ CUSTOM_VTABLE(chat_screen, Screen) {
// Up
local_history.at(self->history_pos) = self->chat->getText();
// Change
int old_pos = self->history_pos;
self->history_pos -= 1;
if (self->history_pos < 0) self->history_pos = local_history.size() - 1;
if (old_pos != self->history_pos) {
self->chat->setText(local_history.at(self->history_pos));
}
self->chat->setText(local_history.at(self->history_pos));
return;
bigjango13 marked this conversation as resolved
TheBrokenRail commented 2024-03-18 23:55:49 +00:00
Review
Copy Link

Is this check needed? Because if old_pos == self->history_pos, wouldn't that just call setText with the current text, doing nothing?

Is this check needed? Because if `old_pos == self->history_pos`, wouldn't that just call `setText` with the current text, doing nothing?
bigjango13 commented 2024-03-18 23:58:58 +00:00
Review
Copy Link

Yep, that's left over.

Yep, that's left over.
} else if (key == 0x28) {
// Down
local_history.at(self->history_pos) = self->chat->getText();
// Change
int old_pos = self->history_pos;
self->history_pos += 1;
if (self->history_pos > int(local_history.size()) - 1) self->history_pos = 0;
if (old_pos != self->history_pos) {
self->chat->setText(local_history.at(self->history_pos));
}
self->chat->setText(local_history.at(self->history_pos));
return;
}
}