TheBrokenRail
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-01-28 22:56:33 +00:00
Add Cake

feature_has should ideally only run once per feature (to avoid redundant log entries). Maybe bucket could set a variable if it's enabled?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-01-28 22:55:25 +00:00
Add Cake

Remove the (* and ).

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-01-28 22:54:19 +00:00
Add Cake

This should probably be static.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-01-28 22:53:38 +00:00
Add Cake

Does FoodItem not have its own constructor?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-01-28 22:53:05 +00:00
Add Cake

Use FoodItem_useTimeDepleted_non_virtual rather than de-referencing the address yourself.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-01-28 22:52:02 +00:00
Add Cake

Do we really care about MCPE compatibility that much? IMO, the code might be nicer if the milk bucket was just a separate item. What are your thoughts?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-01-28 22:50:38 +00:00
Add Cake

Why did you add this to the v2.5.3 changelog?

TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-01-27 22:47:53 +00:00
7c9d16d662 Fix Mistake
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-01-24 04:00:30 +00:00
49f56bd90d Fix Benchmark
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-01-24 02:58:27 +00:00
0b252faa5f Simplify Some Code
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-01-24 01:51:58 +00:00
233e8d691b Fix Tesselator instance symbols
83a282551d Add packet related symbols
29b49ac70a More symbols
118fc6f396 Even more symbols from other projects
e95236023c A few more symbols
Compare 5 commits »
TheBrokenRail merged pull request minecraft-pi-reborn/minecraft-pi-reborn#79 2024-01-24 01:51:57 +00:00
A few more symbols
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-01-24 01:51:48 +00:00
46241c9aa0 Expose Some Properties
f7be586a4c Build On Bullseye
Compare 2 commits »
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#79 2024-01-23 23:10:47 +00:00
A few more symbols

Should this be a pointer?

TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-01-22 00:05:19 +00:00
5c5538df2f Move worldgen desync patch to misc, for LAN games
2995d1c9ad Fix short alignment
b9b44a62bc Fix worldgen desync (and add some symbols)
Compare 3 commits »
TheBrokenRail merged pull request minecraft-pi-reborn/minecraft-pi-reborn#78 2024-01-22 00:05:18 +00:00
Fix worldgen desync (and add some symbols)
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#78 2024-01-21 23:55:32 +00:00
Fix worldgen desync (and add some symbols)

Does this have any impact on how long it takes to join a server? Also, should this be included in misc so it also applies to LAN games?

TheBrokenRail pushed to master at minecraft-pi-reborn/symbol-processor 2024-01-21 23:47:08 +00:00
0b696bd55b Fix short alignment
6b4d6d9239 Add (u)short
Compare 2 commits »
TheBrokenRail merged pull request minecraft-pi-reborn/symbol-processor#7 2024-01-21 23:47:06 +00:00
Add (u)short
TheBrokenRail commented on pull request minecraft-pi-reborn/symbol-processor#7 2024-01-21 23:40:47 +00:00
Add (u)short

This should be 2. You can determine alignment by adding ERR("Alignment: %i", _Alignof(short)); to a file.