TheBrokenRail
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-02-06 23:37:20 +00:00
Add Cake

FoodItem is 3 32-bit ints bigger than Item, but only one is accounted for nutrition. What are the others? This is important because FoodItem is constructed manually and therefore anything not set manually will be left uninitialized.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-02-06 23:31:53 +00:00
Add Cake

So, uh, what does these patches actually do? Does it set an entity ID somewhere? Because that should probably be in the comment.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-02-06 23:25:04 +00:00
Add Cake

This should probably have a comment before it.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-02-06 23:22:19 +00:00
Add Cake

Please add a #pragma once.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#81 2024-02-06 23:21:37 +00:00
Add Cake

Add it to v3.0.0.

TheBrokenRail commented on pull request minecraft-pi-reborn/symbol-processor#8 2024-02-06 23:21:00 +00:00
Add map header

Added.

TheBrokenRail closed pull request minecraft-pi-reborn/symbol-processor#8 2024-02-06 23:21:00 +00:00
Add map header
TheBrokenRail pushed to master at minecraft-pi-reborn/symbol-processor 2024-02-06 23:20:48 +00:00
8bca4b7ec6 Include Map Header On C++
TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#86 2024-02-06 23:04:14 +00:00
Add Food Overlay

Should these constants (79, 70) be put in a macro so they're not repeated?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#86 2024-02-06 23:04:14 +00:00
Add Food Overlay

Maybe call this Gui_blit_renderHearts_original? _injection is a bit unclear IMO. Also, does it not let you do = Gui_blit in this line?

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#86 2024-02-06 23:04:14 +00:00
Add Food Overlay

I'd suggest re-ordering this so that Classic HUD is setup first, then Food Overlay. That way, Food Overlay's overwrites can just replace Classic HUD's rather than Classic HUD's having to explicitly check.

TheBrokenRail commented on pull request minecraft-pi-reborn/minecraft-pi-reborn#86 2024-02-06 23:04:14 +00:00
Add Food Overlay

Overall, looks good!

TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-02-04 08:41:09 +00:00
b5e9486460 Fix Script Bug
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-02-04 07:33:45 +00:00
7fc5638143 Fix CI (Again)
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-02-04 06:31:52 +00:00
7ba9daa84e Fix CI
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-02-04 05:43:36 +00:00
930d0120f3 More CI Improvements
31fcff13e9 CI Improvements
Compare 2 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-02-04 02:08:02 +00:00
41fcc942fa JS-Based Build Script
ddd9226e9e Fix Button Hover
a336cd1c7b Improve Key Handling
eaf6dd2fe2 Add Peaceful Mode To Options Screen
Compare 4 commits »
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-02-02 09:20:47 +00:00
99b43ddb5a Create World Screen + Scrolling Text Boxes!
TheBrokenRail pushed to master at minecraft-pi-reborn/symbol-processor 2024-02-02 04:18:51 +00:00
fbdd1e2798 Small Cleanup
TheBrokenRail pushed to master at minecraft-pi-reborn/minecraft-pi-reborn 2024-02-01 19:56:24 +00:00
4f32cfab45 Send Button In Chat
69211eb31d Improve Markdown Formatting
Compare 2 commits »